Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed optional optimize_for_inference #6933

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

borisfom
Copy link
Collaborator

What does this PR do ?

Removed optional optimize_for_inference call - causes problems with some nets and does not really help otherwise.
Fixed verbose flag passing.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
@borisfom borisfom requested a review from titu1994 June 28, 2023 01:30
@github-actions github-actions bot added the core Changes to NeMo Core label Jun 28, 2023
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@borisfom
Copy link
Collaborator Author

From the PyTorch docs:
Accordingly, serialization is not implemented following invoking optimize_for_inference and is not guaranteed.
This is still in prototype, and may have the potential to slow down your model.

@titu1994 titu1994 merged commit e9b0b11 into NVIDIA:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants